Skip to content

Convers hnoll and kobaloi ears and horns to correct accessory subtypes.#5361

Merged
out-of-phaze merged 1 commit into
NebulaSS13:devfrom
MistakeNot4892:fix/ears
May 14, 2026
Merged

Convers hnoll and kobaloi ears and horns to correct accessory subtypes.#5361
out-of-phaze merged 1 commit into
NebulaSS13:devfrom
MistakeNot4892:fix/ears

Conversation

@MistakeNot4892
Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 commented May 11, 2026

  • Converts hnoll ears, kobaloi ears and kobaloi horns into their respective accessory types.
  • Adds an 'extra' accessory metadata decl (used for tufts on Hnoll ears).
  • Refactors accessory overlay gen to allow a list of metadata types to apply.
  • Renames Default Ears and Default Tail to No Custom Ears and No Custom Tail.
  • Fixes grafadreka spines masking.

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label May 11, 2026
@MistakeNot4892 MistakeNot4892 force-pushed the fix/ears branch 9 times, most recently from 33ff4bc to 4ee5ae7 Compare May 12, 2026 05:09
@MistakeNot4892 MistakeNot4892 changed the title Various ear conversion/fixes. Convers hnoll and kobaloi ears and horns to correct accessory subtypes. May 12, 2026
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels May 12, 2026
@MistakeNot4892 MistakeNot4892 marked this pull request as ready for review May 12, 2026 05:35
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in theory this change means you can't have one floppy ear and one stubby ear, which i think you could before, but that's... probably fine...?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other species have ears as single units so I figured it was better to be consistent - I could add stub ears for the floppy variants too though. The alternative is keeping ears separate and letting multiple ears be selected, but that would need some work on the hnoll, tajaran and teshari sides as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make a tracking issue for readding it, converting them is more important for now

Comment thread mods/content/fantasy/datum/kobaloi/horns.dm
@out-of-phaze out-of-phaze merged commit 778d982 into NebulaSS13:dev May 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is ready for review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants