[Necrosource AI] Mini-map doesn't show when map size is over 682 walkable hexes#1358
Open
necrosource-bot[bot] wants to merge 1 commit into
Open
[Necrosource AI] Mini-map doesn't show when map size is over 682 walkable hexes#1358necrosource-bot[bot] wants to merge 1 commit into
necrosource-bot[bot] wants to merge 1 commit into
Conversation
Automated fix by Necrosource AI agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix
Issue: Mini-map doesn't show when map size is over 682 walkable hexes
QA Review
APPROVE: The fix correctly addresses the root cause — the hardcoded
scale = 24caused intermediate texture dimensions to exceed SDL's16384pxGPU limit for maps ≥ 683 hexes.Math verification:
map.w() * scale * 3/4 ≤ max_w→scale ≤ max_w * 4 / (map.w() * 3)✓map.h() * scale ≤ max_h→scale ≤ max_h / map.h()✓Edge cases handled:
map.w() > 0 && map.h() > 0guard prevents division by zero ✓SDL_GetRendererInforeturn value checked andmax_texture_width/height > 0validated ✓std::max(1, ...)prevents zero-size texture ✓No regressions expected:
scaleis the same local variable used downstream, so all dimension calculations in the function automatically use the reduced valueMinor concern (non-blocking):
std::min({...})with an initializer list requires<algorithm>, but this is almost certainly already included in a rendering-heavy file likeminimap.cpp.This PR was generated by the Necrosource AI agent team.