feature/CSTACKEX-46: Create, Delete iSCSI type Cloudstack volumes, Enter, Cancel Maintenance mode #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Storage pool workflows
…cel Maintenance mode
sandeeplocharla
requested review from
piyush5netapp,
rajiv-jain-netapp and
suryag1201
added 3 commits
January 22, 2026 13:24
…base and renamed plugin name
…base in agent code
…ragePool create and delete
sandeeplocharla
commented
Jan 27, 2026
| if (volumeVO != null) { | ||
| volumeVO.setPath(null); | ||
| if (cloudStackVolume.getLun().getUuid() != null) { | ||
| volumeVO.setFolder(cloudStackVolume.getLun().getUuid()); |
Collaborator
Author
There was a problem hiding this comment.
Add a comment on the need for this
| if (mapResp != null && mapResp.containsKey(Constants.LOGICAL_UNIT_NUMBER)) { | ||
| String lunNumber = mapResp.get(Constants.LOGICAL_UNIT_NUMBER); | ||
| s_logger.info("ensureLunMapped: Existing LunMap found for LUN [{}] in igroup [{}] with LUN number [{}]", lunName, accessGroupName, lunNumber); | ||
| return lunNumber; |
Collaborator
Author
There was a problem hiding this comment.
Add a TODO comment to keep an eye on possibility of duplicate LUN for luns
| VolumeVO volumeVO = volumeDao.findById(volInfo.getId()); | ||
| if (volumeVO != null) { | ||
| String iscsiPath = Constants.SLASH + storagePool.getPath() + Constants.SLASH + lunNumber; | ||
| volumeVO.set_iScsiName(iscsiPath); |
Collaborator
Author
There was a problem hiding this comment.
Remove any redundant code
| return false; | ||
| } | ||
| // Set the aggregates which are according to the storage requirements | ||
| for (Aggregate aggr : aggrs) { |
Collaborator
Author
There was a problem hiding this comment.
Check for rebase issue here
| Map<String, Object> queryParams = Map.of("allow_delete_while_mapped", "true"); | ||
| try { | ||
| sanFeignClient.deleteLun(authHeader, cloudstackVolume.getLun().getUuid(), queryParams); | ||
| } catch (Exception ex) { |
Collaborator
Author
There was a problem hiding this comment.
Check if feignException should be added
| String authHeader = Utility.generateAuthHeader(storage.getUsername(), storage.getPassword()); | ||
| sanFeignClient.deleteLunMap(authHeader, lunUUID, igroupUUID); | ||
| s_logger.info("disableLogicalAccess: LunMap deleted successfully."); | ||
| } catch (Exception e) { |
Collaborator
Author
There was a problem hiding this comment.
Use feignException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has the following changes:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Passcode: n=AE=.C9
Passcode: $%j3+K4B
Observations:
Though we have increased retries to wait for discovery of luns, the additional volume attachment still times out, so, it needs a manual retry.
When placed into Maintenance mode, Instance is getting Stopped in the first case while it remains in Running state in the second case. We currently don't have any code attributing to this behaviour in our plugin code. Need to understand why cloudstack is behaving this way.
I've also tested force delete of storage pool when CS volumes were present, but, haven't covered it in these recordings.