CSTACKEX-114: Delete volume or qcow2 file NFS#32
Conversation
...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
Show resolved
Hide resolved
| } | ||
| Map<String, String> details = storagePoolDetailsDao.listDetailsKeyPairs(store.getId()); | ||
| if (ProtocolType.NFS3.name().equalsIgnoreCase(details.get(Constants.PROTOCOL))) { | ||
| // ManagedNFS qcow2 backing file deletion handled by KVM host/libvirt; nothing to do via ONTAP REST. |
There was a problem hiding this comment.
you can keep this comment since this stands valid
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
| } | ||
| } | ||
|
|
||
| private Answer deleteVolumeOnKVMHost(DataObject volumeInfo) { |
There was a problem hiding this comment.
Is there a way to include this in cloudstack core code, instead of having it here?
This looks like a good candidate for contributing to the community.
rajiv-jain-netapp
left a comment
rajiv-jain-netapp
left a comment
There was a problem hiding this comment.
- add the test cases you ran and update the JUnit coverage after the unit test changes.
- Include the test cases you executed and refresh the JUnit coverage following the recent unit test updates."
rajiv-jain-netapp
left a comment
rajiv-jain-netapp
left a comment
There was a problem hiding this comment.
Some comments, but they should not block this merge. Let's ensure we track these comment changes as part of jira task.
|
|
||
| } else if (ProtocolType.NFS3.name().equalsIgnoreCase(details.get(Constants.PROTOCOL))) { | ||
| // For NFS, the hypervisor handles file creation; we only track pool association | ||
| createCmdResult = new CreateCmdResult(volInfo.getUuid(), new Answer(null, true, null)); |
There was a problem hiding this comment.
these has to be refactored using strategy patterns. please create a task in the back log to be picked without fail.
| String svmName = details.get(Constants.SVM_NAME); | ||
| String cloudStackVolumeName = volumeDetailsDao.findDetail(volumeVO.getId(), Constants.LUN_DOT_NAME).getValue(); | ||
|
|
||
| if (ProtocolType.ISCSI.name().equalsIgnoreCase(details.get(Constants.PROTOCOL))) { |
There was a problem hiding this comment.
@sandeeplocharla @piyush5netapp these have to be handled with strategy implementation we already have instead if-else for protocol.
| port = Constants.NFS3_PORT; | ||
| s_logger.info("Setting NFS path for storage pool: " + path + ", port: " + port); | ||
| // Force NFSv3 for ONTAP managed storage to avoid NFSv4 ID mapping issues | ||
| details.put("nfsmountopts", "vers=3"); |
There was a problem hiding this comment.
lets put hardcoding in constants
|
Create Jira https://jira.ngage.netapp.com/browse/CSTACKEX-119 to track the review comments. |
3 participants
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?