Skip to content

Bug fix to allow the calls to webhook APIs to succeed when using GuildThread. #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AraHaan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bug fix to allow the calls to webhook APIs to succeed when using GuildThread. #351

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b7b98d
Bug fix to allow the calls to webhook APIs to succeed when using Guil…
AraHaan May 26, 2026
d36931a
Leave the existing methods from TextGuildChannel and ForumGuildChanne…
AraHaan May 26, 2026
04ef2da
Hide original CreateWebhookAsync and GetChannelWebhooksAsync from Tex…
AraHaan May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NetCord/Rest/RestClient.Webhook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ namespace NetCord.Rest;

public partial class RestClient
{
[GenerateAlias([typeof(GuildThread)], $"(ulong){nameof(TextGuildChannel.ParentId)}!", Modifiers = ["new"])]
[GenerateAlias([typeof(ForumGuildChannel)], nameof(ForumGuildChannel.Id))]
[GenerateAlias([typeof(TextGuildChannel)], nameof(TextGuildChannel.Id))]
public async Task<IncomingWebhook> CreateWebhookAsync(ulong channelId, WebhookProperties webhookProperties, RestRequestProperties? properties = null, CancellationToken cancellationToken = default)
Expand All @@ -12,6 +13,7 @@ public async Task<IncomingWebhook> CreateWebhookAsync(ulong channelId, WebhookPr
return new(await (await SendRequestAsync(HttpMethod.Post, content, $"/channels/{channelId}/webhooks", null, new(channelId), properties, cancellationToken: cancellationToken).ConfigureAwait(false)).ToObjectAsync(Serialization.Default.JsonWebhook).ConfigureAwait(false), this);
}

[GenerateAlias([typeof(GuildThread)], $"(ulong){nameof(TextGuildChannel.ParentId)}!", Modifiers = ["new"])]
[GenerateAlias([typeof(ForumGuildChannel)], nameof(ForumGuildChannel.Id))]
[GenerateAlias([typeof(TextGuildChannel)], nameof(TextGuildChannel.Id))]
public async Task<IReadOnlyList<Webhook>> GetChannelWebhooksAsync(ulong channelId, RestRequestProperties? properties = null, CancellationToken cancellationToken = default)
Expand Down