-
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
jpegli: init at 0-unstable-2025-02-11 #462987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
| repo = "jpegli"; | ||
| rev = "bc19ca2393f79bfe0a4a9518f77e4ad33ce1ab7a"; | ||
| hash = "sha256-8th+QHLOoAIbSJwFyaBxUXoCXwj7K7rgg/cCK7LgOb0="; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to unvendor everything in the third_party directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking in the OG package (libjxl) and there it's the same way, there are too many vendored sub-modules that making it work will need a bunch of changes in their cmake.
jpegli is an improved JPEG encoder and decoder implementation.
Fixes #361872
closes #413118
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.