-
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
cross: Fix shebang of installed python scripts #462993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
Closes: NixOS#449340 Fixes: NixOS#449325
|
|
For whatever reason, nixpkgs-review refused to build it. It tried and then killed it in the middle of the import check. I'm running a build manually right now. |
45781cc to
6724e26
Compare
|
maybe it's because it's failing the formatting ci so it can't reuse the evaluation from ci? |
|
But wouldn't it have not built it? It tried building the derivation, stopped half way through with no error in the nix build, and then nixpkgs-review tried getting the logs but failed (presumably because the build didn't finish). |
RossComputerGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build the derivation from the issue, this should be gtg once CI is green.
An alternative to the below PR
Closes: #449340
Fixes: #449325
It uses a patch to
installerthat was accepted upstream, then reverted because it was too much functionality and if somebody wants it they should implement a different frontend to theinstallercommand usinginstalleras a library. For now we just need one more CLI flag so the burden of carrying this patch is lower to the one of copy pasting the CLI part ofinstallerwith the patch.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.