Skip to content

Conversation

@symphorien
Copy link
Member

An alternative to the below PR

Closes: #449340
Fixes: #449325

It uses a patch to installer that was accepted upstream, then reverted because it was too much functionality and if somebody wants it they should implement a different frontend to the installer command using installer as a library. For now we just need one more CLI flag so the burden of carrying this patch is lower to the one of copy pasting the CLI part of installer with the patch.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@symphorien symphorien changed the title Fix shebang of installed python scripts cross: Fix shebang of installed python scripts Nov 18, 2025
@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 462993 --package pkgsLLVM.python313Packages.pytest
Commit: 45781cc53ed1d218bae636a4c75d61f4457e38f0


aarch64-linux

❌ 3 packages failed to build:
  • pkgsLLVM.python313Packages.pytest
  • pkgsLLVM.python313Packages.pytest.dist (pkgsLLVM.python313Packages.pytest.dist.dist, pkgsLLVM.python313Packages.pytest.dist.testout)
  • pkgsLLVM.python313Packages.pytest.testout (pkgsLLVM.python313Packages.pytest.testout.dist, pkgsLLVM.python313Packages.pytest.testout.testout)

@RossComputerGuy
Copy link
Member

For whatever reason, nixpkgs-review refused to build it. It tried and then killed it in the middle of the import check. I'm running a build manually right now.

@symphorien symphorien changed the base branch from master to staging November 18, 2025 20:25
@nixpkgs-ci nixpkgs-ci bot closed this Nov 18, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Nov 18, 2025
@symphorien symphorien force-pushed the python-installer-cross branch from 45781cc to 6724e26 Compare November 18, 2025 20:28
@symphorien
Copy link
Member Author

maybe it's because it's failing the formatting ci so it can't reuse the evaluation from ci?

@RossComputerGuy
Copy link
Member

But wouldn't it have not built it? It tried building the derivation, stopped half way through with no error in the nix build, and then nixpkgs-review tried getting the logs but failed (presumably because the build didn't finish).

Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build the derivation from the issue, this should be gtg once CI is green.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 18, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: pkgsLLVM.python313Packages.pytest

2 participants