Skip to content

various: add versions to unstable tag #462998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

various: add versions to unstable tag #462998

wants to merge 8 commits into from

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Nov 18, 2025 •
edited
Loading

  • add versions to unstable tag with nix-update --version=branch

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@guylamar2006 guylamar2006 requested a review from Copilot November 18, 2025 20:29
Copilot finished reviewing on behalf of guylamar2006 November 18, 2025 20:31
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates version strings for several packages to comply with nixpkgs versioning guidelines by ensuring all versions start with a digit. The changes add proper version prefixes to packages that were using the old "unstable-YYYY-MM-DD" format, converting them to the required "X.Y.Z-unstable-YYYY-MM-DD" or "0-unstable-YYYY-MM-DD" format.

  • Adds version prefixes to unstable package versions per nixpkgs guidelines
  • Updates source revisions and hashes for packages with actual upstream updates
  • Ensures all version strings start with a digit as required for nix-env compatibility

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkgs/by-name/ww/wwcd/package.nix Adds "0-" prefix to unstable version string
pkgs/by-name/wa/waylogout/package.nix Updates to version 0.3 with new commit and hash
pkgs/by-name/rk/rkdeveloptool/package.nix Adds "0-" prefix to unstable version string
pkgs/by-name/rk/rkdeveloptool-pine64/package.nix Adds "1.1.8-" prefix to unstable version string
pkgs/by-name/jo/joomscan/package.nix Updates to version 0.0.7 with new commit and hash
pkgs/by-name/go/google-fonts/package.nix Updates to version 0.4.9 with new commit and hash
pkgs/by-name/bf/bfscripts/package.nix Updates to version 3.9.7-1 with new commit and hash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Nov 18, 2025
@guylamar2006
Copy link
Contributor Author

guylamar2006 commented Nov 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 462998
Commit: 364e6636b55198992a63001493b029071162c759 (subsequent changes)
Merge: 23345d8ccb58e9afa240a7db8fe97ff77df1b69d

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/19482195688

x86_64-linux

✅ 9 packages built:
  • bfscripts
  • crabfit-frontend
  • joomscan
  • linkwarden
  • ricty
  • rkdeveloptool
  • rkdeveloptool-pine64
  • waylogout
  • wwcd

aarch64-linux

✅ 8 packages built:
  • bfscripts
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • rkdeveloptool-pine64
  • waylogout
  • wwcd

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • rkdeveloptool-pine64
✅ 5 packages built:
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • wwcd
Error logs: `x86_64-darwin`
rkdeveloptool-pine64 
The Meson build system
Version: 1.9.1
Source dir: /nix/build/nix-8335-4049969616/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3
Build dir: /nix/build/nix-8335-4049969616/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3/build
Build type: native build
Project name: rkdeveloptool
Project version: 1.0.0
C++ compiler for the host machine: clang++ (clang 21.1.2 "clang version 21.1.2")
C++ linker for the host machine: clang++ ld64 954.16
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: YES (/nix/store/1y5rd6if5c5ybfkmx6417lfwciy5zsf7-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.2
Run-time dependency libusb-1.0 found: YES 1.0.29
Configuring config.h using configuration
Found CMake: /nix/store/50cyzhv59gzf62fyncqpgwmxdrdzx7aj-cmake-4.1.2/bin/cmake (4.1.2)
Run-time dependency udev found: NO (tried pkgconfig, framework and cmake)

meson.build:26:7: ERROR: Dependency "udev" not found, tried pkgconfig, framework and cmake


A full log can be found at /nix/build/nix-8335-4049969616/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3/build/meson-logs/meson-log.txt

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • rkdeveloptool-pine64
✅ 5 packages built:
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • wwcd
Error logs: `aarch64-darwin`
rkdeveloptool-pine64 
The Meson build system
Version: 1.9.1
Source dir: /nix/build/nix-8013-2938354057/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3
Build dir: /nix/build/nix-8013-2938354057/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3/build
Build type: native build
Project name: rkdeveloptool
Project version: 1.0.0
C++ compiler for the host machine: clang++ (clang 21.1.2 "clang version 21.1.2")
C++ linker for the host machine: clang++ ld64 954.16
Host machine cpu family: aarch64
Host machine cpu: aarch64
Found pkg-config: YES (/nix/store/hcjg5lssxg44z5nx1vnc3yzhlw5arzdj-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.2
Run-time dependency libusb-1.0 found: YES 1.0.29
Configuring config.h using configuration
Found CMake: /nix/store/y5q690ckylx7w0ixjn2s2yf2w0bvvb69-cmake-4.1.2/bin/cmake (4.1.2)
Run-time dependency udev found: NO (tried pkgconfig, framework and cmake)

meson.build:26:7: ERROR: Dependency "udev" not found, tried pkgconfig, framework and cmake


A full log can be found at /nix/build/nix-8013-2938354057/rkdeveloptool-17823e99898131a234ccdb39ad114dbaeebb7fc3/build/meson-logs/meson-log.txt

@guylamar2006
waylogout: unstable-2023-06-09 -> 0.3-unstable-2025-07-30
f08088e 
Diff: loserMcloser/waylogout@f90e1b8...e3ab4da
@guylamar2006
rkdeveloptool: unstable-2025-03-07 -> 0-unstable-2025-03-07
2a6e424 
Diff: rockchip-linux/rkdeveloptool@304f073...304f073
@guylamar2006
google-fonts: unstable-2024-06-21 -> 0.4.9-unstable-2025-11-14
14c60e8 
Diff: google/fonts@d5ea309...5f31230
@guylamar2006
wwcd: unstable-2022-02-05 -> 0-unstable-2022-02-05
e79280a
@guylamar2006
bfscripts: unstable-2025-06-27 -> 3.9.7-1-unstable-2025-11-18
4ab384c 
Diff: Mellanox/bfscripts@ed8ede7...1bc9bdf
@guylamar2006
rkdeveloptool-pine64: unstable-2022-12-01 -> 1.1.8-unstable-2022-12-01
32d0b9a
@guylamar2006
joomscan: unstable-2021-06-08 -> 0.0.7-unstable-2023-11-30
20f6206 
Diff: OWASP/joomscan@7931539...2ea8cc7
@guylamar2006
rkdeveloptool-pine64: fix build failure on darwin
a6ee112 
 - add missing udev package for darwin
@guylamar2006 guylamar2006 requested a review from Copilot November 18, 2025 22:43
Copilot finished reviewing on behalf of guylamar2006 November 18, 2025 22:45
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guylamar2006
Copy link
Contributor Author

guylamar2006 commented Nov 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 462998
Commit: a6ee1121c3ea99fc3dcc680106c10bc3806fa79e (subsequent changes)
Merge: f0a7f6ce5416a64d4af311f3dde4e6c5b8bdc6da

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/19482939553

x86_64-linux

✅ 9 packages built:
  • bfscripts
  • crabfit-frontend
  • joomscan
  • linkwarden
  • ricty
  • rkdeveloptool
  • rkdeveloptool-pine64
  • waylogout
  • wwcd

aarch64-linux

✅ 8 packages built:
  • bfscripts
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • rkdeveloptool-pine64
  • waylogout
  • wwcd

x86_64-darwin (sandbox = relaxed)

✅ 5 packages built:
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • wwcd

aarch64-darwin (sandbox = relaxed)

✅ 5 packages built:
  • crabfit-frontend
  • joomscan
  • ricty
  • rkdeveloptool
  • wwcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dit7ya dit7ya Awaiting requested review from dit7ya

@emilytrau emilytrau Awaiting requested review from emilytrau

@laalsaas laalsaas Awaiting requested review from laalsaas

@lopsided98 lopsided98 Awaiting requested review from lopsided98

@manveru manveru Awaiting requested review from manveru

@nikstur nikstur Awaiting requested review from nikstur

@thillux thillux Awaiting requested review from thillux

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guylamar2006