Skip to content

Conversation

@Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Nov 20, 2025

Closes #149685

All the issues fixed now, and polari can launch as a standalone app without telepathy service (and use the service if exists)!

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 20, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 21, 2025
@Aleksanaa Aleksanaa marked this pull request as ready for review November 21, 2025 16:51
# and chat history spinning forever on second launch.
# Fixes the race condition by ensuring all callers wait on the
# same shared initialization promise
./fix_sparql_database_race.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is written by me, but I can't submit it upstream because gitlab.gnome.org sets a limit on my newly created account ...

Comment on lines +48 to +56
# fix TypeError: (intermediate value).get_current_event_device is not a function
# https://gitlab.gnome.org/GNOME/polari/-/merge_requests/320
./0001-joinDialog-Fix-detecting-pointer-devices.patch

# https://gitlab.gnome.org/GNOME/polari/-/merge_requests/329
./0002-mainWindow-Disconnect-event-handler-on-destroy.patch

# https://gitlab.gnome.org/GNOME/polari/-/merge_requests/330
./0003-Add-option-to-disable-URL-preview-feature.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three are following https://gitlab.archlinux.org/archlinux/packaging/packages/polari. IMO they are good to have but not necessarily blocking functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polari does not work

1 participant