Skip to content

envoy: drop unused jdk blobs from deps tarball #466866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

envoy: drop unused jdk blobs from deps tarball #466866

merged 1 commit into from
Dec 2, 2025

Conversation

@TerrorJack
Copy link
Member

@TerrorJack TerrorJack commented Dec 1, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from lukegb December 1, 2025 16:13
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 1, 2025
@TerrorJack
Copy link
Member Author

TerrorJack commented Dec 1, 2025

this shrinks the deps tarball to <2G and should allow hydra to build envoy, fixing #438433.

@lukegb
Copy link
Contributor

lukegb commented Dec 1, 2025

This is a great start; thanks :)

@TerrorJack TerrorJack added the backport release-25.11 Backport PR automatically label Dec 1, 2025
@lukegb
Copy link
Contributor

lukegb commented Dec 1, 2025

Hmm, both ofborg and I got sha256-cUpCkmJmFyd2mTImMKt5Cgi+A4bAWAXLYjJjMnV6haQ= for x86_64-linux rather than sha256-xiNRxrwZ71/TywU58snwQO3W3/2ZMX5n1HwfiBsdZMM=, although your aarch64 hash looks fine.

@TerrorJack
Copy link
Member Author

TerrorJack commented Dec 1, 2025

thanks for the correction!

@lukegb lukegb added this pull request to the merge queue Dec 2, 2025
Merged via the queue into NixOS:master with commit 5f53b0d Dec 2, 2025
25 of 29 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 2, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 2, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 2, 2025
@TerrorJack TerrorJack deleted the fix-envoy-deps-size branch December 2, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukegb lukegb Awaiting requested review from lukegb

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TerrorJack @lukegb