speedtest-exporter: init at 1.1.4 + nixos/prometheus-exporters: init speedtest-exporter #467982
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/6134 |
Contributor
|
the correct title should be |
acid-bong
suggested changes
Dec 5, 2025
Contributor
There was a problem hiding this comment.
actually no: split your PR into three commits:
- new package (without test in passthru)
- new module
- new test (and add it to the package's passthru)
See common conventions (one commit per logical unit), individual title conventions + follow dependency order. The final title format should be PROGRAM: init at VERSION + nixos module
nixpkgs-ci
bot
removed
the
9.needs: reviewer
emaiax
force-pushed
the
prometheus-speedtest-exporter
branch
from
2f32986 to
b87e4cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
emaiax
changed the title
acid-bong
reviewed
Dec 5, 2025
Comment on lines
+23
to
+24
| "-X main.builtBy=nixpkgs" | ||
| "-X main.commit=unknown" | ||
| "-X main.date=unknown" |
Contributor
There was a problem hiding this comment.
where did you get these from? i can only see version
Contributor
Author
There was a problem hiding this comment.
There are other compiled packages that I used as examples:
- https://github.com/emaiax/nixpkgs/blob/prometheus-speedtest-exporter/pkgs/by-name/pr/prometheus-alertmanager/package.nix
- https://github.com/emaiax/nixpkgs/blob/prometheus-speedtest-exporter/pkgs/by-name/pr/prometheus-mysqld-exporter/package.nix
- https://github.com/emaiax/nixpkgs/blob/prometheus-speedtest-exporter/pkgs/by-name/pr/prometheus-node-exporter/package.nix
emaiax
force-pushed
the
prometheus-speedtest-exporter
branch
from
aea4b7d to
abaabd3
Compare
Reintroduces `speedtest-exporter` enabling Prometheus metrics export for Ookla speedtests (runtime dependency).
Introduces a new NixOS module for the Prometheus speedtest exporter, allowing configuration of debug mode and refresh interval.
Add tests for the prometheus-speedtest-exporter, enabling service, debug mode, and refresh interval configuration. Also links the test in the package's passthru.tests for integration with NixOS test infrastructure.
emaiax
force-pushed
the
prometheus-speedtest-exporter
branch
from
abaabd3 to
c358fb2
Compare
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the
prometheus-speedtest-exporterpackage and nixos module for configuring the prometheus speedtest-exporter. This enables monitoring of network speed metrics via Prometheus using the Ookla Speedtest CLI.speedtest-exporter timeline:
not plannedThe caarlos0/speedtest-exporter has been working for years without issues, so I think it's a solid option to bring this exporter back. This exporter requires pkgs/by-name/oo/ookla-speedtest to be available in runtime; however, speedtest-cli is proprietary software.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.