-
-
Notifications
You must be signed in to change notification settings - Fork 34
Page loading rework and more #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gtk is not thread safe, so this way all gtk calls should be made in the main thread Added some helper functions to Page to make populating pages easier.
ea3576f to
db9a640
Compare
|
bro has been cooking :0 I say we do a major release when this is merged (so 1.0.0) |
hahahahah, thanks
Was thinking this too |
drafolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; will check locally
|
@youwen5 I figured out the issue with your first screenshot, but since my account doesn't have anything |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I hope the issue with featured items it's now fixed. If someone can confirm it I can merge this. |
drafolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two changes that could improve code readability and DX.
I am currently in the process of reinstalling my system so i can't check if it works right now 😅
drafolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested in an arch gnome box, and it definitely works






This MR includes various things: