Fixes #27927: Add a schedule module#6739
Merged
Normation-Quality-Assistant merged 1 commit intoNormation:branches/rudder/9.1from Mar 3, 2026
Merged
Conversation
amousset
force-pushed
the
bug_27927/add_a_schedule_module
branch
3 times, most recently
from
f802843 to
e1d97e4
Compare
Member
Author
|
PR updated with a new commit |
2 similar comments
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
amousset
force-pushed
the
bug_27927/add_a_schedule_module
branch
from
7a54b05 to
da5b9ca
Compare
Member
Author
|
PR updated with a new commit |
2 similar comments
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
amousset
force-pushed
the
bug_27927/add_a_schedule_module
branch
from
7aaf8a1 to
e776a53
Compare
amousset
force-pushed
the
bug_27927/add_a_schedule_module
branch
from
e776a53 to
3917b95
Compare
Member
Author
|
PR updated with a new commit |
4 similar comments
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
Member
Author
|
PR updated with a new commit |
m4rtinh4rt
reviewed
Feb 26, 2026
| let window = (end - start).num_minutes(); | ||
| bail!( | ||
| "Campaign execution schedule is too short, the minimal schedule should be superior to \ | ||
| "Event schedule windows is too short, the minimal schedule should be superior to \ |
Contributor
There was a problem hiding this comment.
Suggested change
| "Event schedule windows is too short, the minimal schedule should be superior to \ | |
| "Event schedule window is too short, the minimal schedule should be superior to \ |
m4rtinh4rt
reviewed
Feb 26, 2026
| pub fn entry() -> anyhow::Result<(), anyhow::Error> { | ||
| // SAFETY: The module is single-threaded. | ||
| unsafe { | ||
| env::set_var("LC_ALL", "C"); |
Contributor
There was a problem hiding this comment.
Is this required for proper output rendering?
LC_ALL is Unix-only. Do we need something similar for Windows?
Member
Author
There was a problem hiding this comment.
I will be used by some tooling on Windows, so no harm keeping it.
Fdall
approved these changes
Mar 3, 2026
Contributor
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_27927/add_a_schedule_module
branch
from
ce541a6 to
af51d29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/27927
The general behavior is to use the events from the policies, and only use the database as a flag to store that
onceevents have run.Left for later:
cli_tableconfig intorudder_cli.