[18.0][FIX] account_financial_report: display results considering archived accounts and journals #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accounts and journals.
pedrobaeza
approved these changes
Nov 23, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Thanks for bringing this to table. It's true that we are not thinking of that.
| self, workbook, report, res_data, ledger, report_data | ||
| ): | ||
| journal = self.env["account.journal"].browse(ledger["id"]) | ||
| journal = ( |
Member
There was a problem hiding this comment.
This one is loading a journal, so are you sure you require the context here?
|
|
||
| def _generate_journal_taxes_summary(self, workbook, ledger, report_data): | ||
| journal = self.env["account.journal"].browse(ledger["id"]) | ||
| journal = ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archiving a journal or an account should not result in not being able to displaying the financial results related with them. For example, consider a sales journal that you don't want to use going forward. You will still want to see financial activity related with that journal for past periods.