Skip to content

Conversation

@TheMule71
Copy link

header_lines_skip_count should be skipped for CSV files as well

Lenghier esplanation. enumerate() second argument doesn't skip items. It just starts numbering them from a different start than 0. So if you want to skip N rows, you need to slice the list yourself.

header_lines_skip_count should be skipped for CSV files as well
@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

@github-actions
Copy link

github-actions bot commented Feb 9, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 9, 2025
@github-actions github-actions bot closed this Mar 16, 2025
@cvinh
Copy link

cvinh commented Aug 2, 2025

Hello

This PR has to be merged and forward to 17.0 and cherry-picked in #747 indeed
It fixes the case where we want to skip header lines with csv file

@TheMule71 @pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 4, 2025
@pedrobaeza pedrobaeza reopened this Aug 4, 2025
@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this:

/ocabot merge patch

Please fw-port it.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-727-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 4, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-727-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

It seems the patch is not correct.

@pedrobaeza
Copy link
Member

Or well, the tests are not considering the patch.

@cvinh
Copy link

cvinh commented Aug 4, 2025

@pedrobaeza tests are messed up... I'm working on it

@cvinh
Copy link

cvinh commented Aug 4, 2025

Ouch, it was harder that expected... I did another PR #819

@pedrobaeza pedrobaeza closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants