-
-
Notifications
You must be signed in to change notification settings - Fork 472
[16.0][FIX] account_statement_import_sheet_file: skip header_lines for CSV #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
header_lines_skip_count should be skipped for CSV files as well
|
Hi @alexey-pelykh, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Hello This PR has to be merged and forward to 17.0 and cherry-picked in #747 indeed |
|
Hi @alexey-pelykh, |
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix this:
/ocabot merge patch
Please fw-port it.
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-727-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
It seems the patch is not correct. |
|
Or well, the tests are not considering the patch. |
|
@pedrobaeza tests are messed up... I'm working on it |
|
Ouch, it was harder that expected... I did another PR #819 |
header_lines_skip_countshould be skipped for CSV files as wellLenghier esplanation.
enumerate()second argument doesn't skip items. It just starts numbering them from a different start than 0. So if you want to skip N rows, you need to slice the list yourself.