[14.0][BACKPORT] account_statement_import_online_ponto (from 16.0) #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Ponto we can only retrieve data backwards in time. Therefore we override the normal _pull method to create statements in descending order of statement date.
Contributor
|
Hi @alexey-pelykh, |
metaminux
force-pushed
the
14.0_backport_ponto_from_16.0
branch
5 times, most recently
from
fc5e456 to
4802142
Compare
Author
|
I had to take some changes to account_statement_import_online (from #548) Most of them are tests rewrite though... I had to adapt account_statement_import_online_ponto_ing too (not ported to 16.0) Can anyone review this ? @alexey-pelykh ? @NL66278 ? @astirpe ? @vaab ? @victoralmau ? |
…ttempt to modify of posted account.move
…back to load CoA Since odoo/odoo@d0342c8, the default existing company is not getting a CoA automatically, provoking than the current tests fail with the error: odoo.exceptions.UserError: No journal could be found in company My Company (San Francisco) for any of those types: sale Thus, we put tests post-install for being sure localization modules are installed, the same as AccountTestInvoicingCommon does, but we don't inherit from it, as it creates an overhead creating 2 new companies and loading their CoA and some more stuff, while we don't need all of that. Besides, if you don't have `l10n_generic_coa` installed, you can't use another CoA (like `l10n_es`) easily, so we put little code to select the first available CoA.
…er is non-deterministic
…e in ponto transaction create vals
metaminux
force-pushed
the
14.0_backport_ponto_from_16.0
branch
from
4802142 to
b317d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 14.0, account_statement_import_online_ponto have bugs.
Most important bugs are :
Those bugs have been fixed in 16.0, mainly in the migration commit from 15.0 to 16.0
I suggest to backport changes from 16.0 to get same behaviour between versions...