Skip to content

[19.0][MIG] hr_expense_tier_validation: Migration to 19.0#349

Draft
dnplkndll wants to merge 47 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_tier_validation
Draft

[19.0][MIG] hr_expense_tier_validation: Migration to 19.0#349
dnplkndll wants to merge 47 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_tier_validation

Conversation

@dnplkndll
Copy link
Copy Markdown

@dnplkndll dnplkndll commented May 25, 2026

Port of hr_expense_tier_validation to 19.0.

Non-mechanical adaptations worth flagging

  • Line-Level Tier Validation: Refactored hr_expense_tier_validation to inherit from tier.validation and apply multi-step approval gates directly on individual hr.expense records instead of the removed hr.expense.sheet core model.
  • Search Filters: Ported search filter criteria like "Needs my Review" and "Validated" to target hr.expense search views.
  • Test Modernisation: Rewrote unit tests to verify tier validation rules and constraint checks directly on individual hr.expense records in the submitted state.

ps-tubtim and others added 26 commits May 25, 2026 11:33
…validate the tier validation, then the user has to click the Submit to Manager button. By this PR, requester has to click the Submit to Manager button first, then the tier validation is activated.
Currently translated at 100.0% (18 of 18 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_tier_validation/it/
oca-ci and others added 19 commits May 25, 2026 11:33
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (21 of 21 strings)

Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_tier_validation/tr/
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_tier_validation branch 7 times, most recently from 12b7ef6 to cb893b7 Compare May 29, 2026 20:09
dnplkndll added 2 commits May 30, 2026 10:57
hr.expense.sheet was removed in 19.0; retarget tier validation to hr.expense.
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_tier_validation branch from cb893b7 to bfa850e Compare May 30, 2026 14:57
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnplkndll the tier-validation modules have been moved to a separate repository for 19.0: https://github.com/OCA/tier-validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_expense_tier_validation Module hr_expense_tier_validation series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.