[19.0] mig mis_builder_budget & mis_builder_demo#793
Open
sbidoul wants to merge 4 commits into
Open
Conversation
To document the expected return types
OCA-git-bot
added
mod:mis_builder
mod:mis_builder_budget
sbidoul
force-pushed
the
19.0-mig-mis_builder_budget
branch
from
6a228c4 to
95111e6
Compare
AnizR
approved these changes
Jun 2, 2026
Contributor
AnizR
left a comment
AnizR
left a comment
There was a problem hiding this comment.
Code LGTM, thanks!
A refactor that could be great: use Domain objects instead of sticking with lists when playing with domains/filters. I think that it would need a lot of changes therefore, it could be done later in another PR.
Member
Author
Yes I would like to do this. We need to keep backward compatibility on methods that are meant to be overridden so we must accept both a list and a Domain. There is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.