1835 daps refactor proto proto3 with envelope

[JoshuaSBrown]

Ticket

 

Description

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

• - A description of the PR has been provided, and a diagram included if it is a new feature.
• - Formatter has been run
• - CHANGELOG comment has been added
• - Labels have been assigned to the pr
• - A reviwer has been added
• - A user has been assigned to work on the pr
• - If new feature a unit test has been added

Summary by Sourcery

Build:

• Collect protobuf files from the new 1-1-1 proto directory structure in CMake for code generation.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the common proto3 CMake configuration to automatically discover and generate C++ code for protobufs in a new directory layout, including an envelope proto, instead of relying on a previous, likely hard‑coded list.

Flow diagram for CMake proto discovery and C++ generation

flowchart LR
    A[CMake configuration
    common/proto3/common/CMakeLists.txt] --> B[File discovery with GLOB_RECURSE
    ProtoFiles]

    B --> C[Collect *.proto from
    enums/]
    B --> D[Collect *.proto from
    messages/]
    B --> E[Collect *.proto from
    anon/]
    B --> F[Collect *.proto from
    auth/]
    B --> G[Collect envelope.proto]

    C --> H[Aggregated ProtoFiles list]
    D --> H
    E --> H
    F --> H
    G --> H

    H --> I[protobuf_generate LANGUAGE cpp
    OUTPUT C++ sources/headers]

    I --> J[Compile generated C++
    into common proto library]

Loading

File-Level Changes

Change	Details	Files
Update CMake configuration to glob proto files according to the new 1-1-1 directory structure and include the envelope proto in code generation.	Add GLOB_RECURSE to collect .proto files from enums, messages, anon, and auth subdirectories under the common proto3 directory. Explicitly include envelope.proto in the set of protobuf sources passed to protobuf_generate for C++ generation. Prepare build system to work with the refactored proto layout without manual updates when new protos are added.	common/proto3/common/CMakeLists.txt

Possibly linked issues

• #[Refactor] - Rework Protobuf files following protobuf design Principles: PR restructures proto files into 1-1-1 layout and proto3, directly implementing the protobuf refactor issue.
• #Refactor: PR updates common/proto3 CMake and protos to the new proto3 structure requested by the refactor issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider adding CONFIGURE_DEPENDS to the file(GLOB_RECURSE ...) call so that CMake regenerates the build system when new .proto files are added to these directories.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding CONFIGURE_DEPENDS to the file(GLOB_RECURSE ...) call so that CMake regenerates the build system when new .proto files are added to these directories.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}