Disable blobs in EL #376
Disable blobs in EL #376
Conversation
OisinKyne
left a comment
OisinKyne
left a comment
There was a problem hiding this comment.
leaving unrelated comments about pruning/history, but the blobcount flags look correct
compose-el.yml
Outdated
| --Sync.AncientBodiesBarrier=${NETHERMIND_ANCIENT_BODIES_BARRIER:-0} | ||
| --Sync.AncientReceiptsBarrier=${NETHERMIND_ANCIENT_RECEIPTS_BARRIER:-0} |
There was a problem hiding this comment.
Setting 0 would mean downloading the full chain. shouldnt we bump this to like 20000000 or higher? (currently at 23.7m on mainnet)
There was a problem hiding this comment.
Digging a little further, does it make sense to prune history with this flag
and maybe we need a pruning trigger too? not clear to me if pruning will happen without one? (doesn't seem right that it wouldn't unless this is set, so maybe i don't understand, maybe its the difference between in-memory pruning vs full pruning, which is what hybrid offers)
compose-el.yml
Outdated
| --http.addr=0.0.0.0 | ||
| --http.port=8545 | ||
| --metrics=0.0.0.0:8008 | ||
| --txpool.blobpool-max-count=0 |
There was a problem hiding this comment.
Looks like reth defaults to no pruning (archive node), we should fix that or we'll eat everyone's disk if they swap to reth
compose-el.yml
Outdated
| --Sync.AncientReceiptsBarrier=4367322 | ||
| --Sync.AncientBodiesBarrier=${NETHERMIND_ANCIENT_BODIES_BARRIER:-0} | ||
| --Sync.AncientReceiptsBarrier=${NETHERMIND_ANCIENT_RECEIPTS_BARRIER:-0} | ||
| --TxPool.BlobsSupport=Disabled |
There was a problem hiding this comment.
I have a new concern about this. IIUC, an update was made to allow a CL to fetch blobs from a local ELs mempool. analysis showed that 30-70% of all blobs get imported this way depending on the client. Disabling the blobpool may hurt performance more than we gain from not proposing blobs in the rare case of a local block. Maybe nethermind will separate this behaviours into a different flag. we probably shouldn't turn on this feature if my concern is valid, will try and dig up the reference i remember on twitter.
There was a problem hiding this comment.
NethermindEth/nethermind#9686. Nethermind addressed this for us :D --Blocks.BlockProductionBlobLimit option
DiogoSantoss
force-pushed
the
kalo/disable-blobs-el
branch
from
a5dbe99 to
dee543b
Compare
No description provided.