Add deploy task support for DeployAt and DeployAtExpiry#354
Conversation
grace-rehn
left a comment
There was a problem hiding this comment.
LGTM
Just a small question around error handling:
Would it be worth adding date format validation, or will an invalid format be caught server side? Just want to check its doesn't silently fail
Fair point. There's no user-facing validation per se, so it depends on what we consider an error state and what we mean by "fail". Currently, if the parameters can't be parsed as a datetime (while we prompt for ISO 8601 for consistency, any datetime format will technically work), they will be treated as null and ignored. To save us from future support requests, I'll add some basic error handling if the user doesn't specify a valid date. |


Adds
DeployAtandDeployAtExpiryinputs to the Deploy Release task (Deploy V6 and V7).Prior to the replacement of the .NET CLI with the Executions API deprecation in V6, users could pass
--deployAtand--deployAtExpiryas raw command line parameters via the now deprecatedAdditionalArgumentsinput. When the CLI was swapped out for the TypeScript client, these were not ported to first-class inputs.Both inputs are optional (surfaced under "Additional Options") and accept ISO 8601 date-time strings.