fix: enforce explicit version validation in route-ids-for-agency

[3rabiii]

Description

This PR addresses a specification gap in the route-ids-for-agency endpoint by implementing strict validation for the version query parameter.

Previously, the endpoint ignored the version parameter and returned a 200 OK regardless of the input. This update ensures the handler correctly identifies unsupported versions and rejects them with a semantically correct 400 Bad Request, aligning with RESTful best practices.

Changes Included:

• Version Parsing & Validation: Updated the endpoint handler to explicitly parse and check the version query parameter.
• HTTP 400 Bad Request: Configured the handler to immediately return a 400 Bad Request error with the exact plaintext message "unknown version: {n}" if the provided version is anything other than "2".
• New Unit Test: Added TestRouteIdsForAgencyInvalidVersion to verify that providing an invalid version (e.g., version=99) correctly triggers the 400 Bad Request and returns the expected error text.

fixes: #972

[coderabbitai]

Warning

Review limit reached

@3rabiii, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dfa1cfce-fabc-4984-9edd-bcc909570bcf

📥 Commits

Reviewing files that changed from the base of the PR and between ca166fa and 71610ef.

📒 Files selected for processing (2)

• internal/restapi/route_ids_for_agency_handler.go
• internal/restapi/route_ids_for_agency_handler_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud