fix: return HTTP 404 for unknown agency ID in stop-ids-for-agency

[ARCoder181105]

Summary

Fixed stop-ids-for-agency endpoint to return HTTP 404
when an unknown agency ID is provided instead of
HTTP 200 with a null body.

Problem

When an unknown agency ID is provided, the endpoint
was returning HTTP 200 with a null body instead of
a proper HTTP 404 response.

Changes

• Updated agency handler to call sendNotFound() when
  agency ID is not found in the transit graph

Testing

Before fix:
Request: GET /api/where/stop-ids-for-agency/999.json?key=test
HTTP Status: 200
Body: null

After fix:
Request: GET /api/where/stop-ids-for-agency/999.json?key=test
HTTP Status: 404
Body: {"code":404,"currentTime":1779991625902,"text":"resource not found","version":2}

Spec Reference

https://github.com/OneBusAway/maglev/wiki/stop-ids-for-agency

Proof

Closes #974

[coderabbitai]

Warning

Review limit reached

@ARCoder181105, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a809fd6-c870-40c8-90b7-fc1f197aa349

📥 Commits

Reviewing files that changed from the base of the PR and between d259682 and f3da5d9.

📒 Files selected for processing (2)

• internal/restapi/stop_ids_for_agency_handler.go
• internal/restapi/stop_ids_for_agency_handler_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ARCoder181105]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.