adding PAF userId and RTD modules to prebid#88
Merged
RomainLofaso merged 4 commits intomainfrom Apr 26, 2022
Merged
Conversation
Contributor
There was a problem hiding this comment.
any particular reason to remove this?
Collaborator
Author
There was a problem hiding this comment.
no i will set it back, but i cant get it to load the new version using this method, not sure wht
Collaborator
Author
There was a problem hiding this comment.
no i will set it back, but i cant get it to load the new version using this method, not sure wht
Contributor
There was a problem hiding this comment.
We can investigate together what is going wrong if you want.
paf-mvp-frontend/src/lib/paf-lib.ts
Outdated
Contributor
There was a problem hiding this comment.
[NIT] I guess you can already assume it is going to be async ;-)
bwschmidt
force-pushed
the
paf_modules
branch
3 times, most recently
from
a3279b0 to
399fa63
Compare
Contributor
There was a problem hiding this comment.
extra </script> to remove
paf-mvp-frontend/src/lib/paf-lib.ts
Outdated
Contributor
There was a problem hiding this comment.
Can we define the signature of the callback? From I read, it should be something like that:
callback?: (seed: Seed) =>void;
RomainLofaso
approved these changes
Apr 25, 2022
bwschmidt
force-pushed
the
paf_modules
branch
2 times, most recently
from
73ca793 to
25840b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, see openx/Prebid.js#46 for details