Fix normalization to prevent unnecessary allOf wrapping for oneOf and anyOf#22579
Closed
lucy66hw wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
Fix normalization to prevent unnecessary allOf wrapping for oneOf and anyOf#22579lucy66hw wants to merge 2 commits intoOpenAPITools:masterfrom
lucy66hw wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
@wing328 Could you please review? |
Member
|
@lucy66hw thanks for the PR here is how i look at the issue. ideally the following should be handled without any issue (in any usage), right? i think your PR is more like a workaround/patch to address a particular use case. the above use of allOf can be handled properly (e.g. as a property in model) but not everywhere (e.g. sub-schema in oneOf), which is definitely something I think we should address. |
Contributor
Author
|
@wing328 Thanks. Just to clarify—are you suggesting we should make the generator resolution handle allOf([$ref]) even when it appears as a oneOf sub-schema, rather than changing it in the normalizer? |
Member
|
my understanding is that we don't need this any more. happy to reopen if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement context-aware normalization with isInComposition flag to skip normalization for oneOf/anyOf items.
#22578
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)