Improved Linux detection fixes by XenHat · Pull Request #143 · OpenAsar/arrpc

XenHat · 2025-03-13T16:40:38Z

This is a re-implementation of #92 with additional fixes for more games, and should be compatible with #130 as I have validated the code against the current upstream database.

The following games have been verified to be correctly detected on Linux:

KNOWN ISSUES:

Red Dead Redemption 2 (Broken)
Zenless Zone Zero (Needs re-test)
Untested on Windows, but should work.
Many Linux Native titles are not detected (Missing from the Discord DB)

Main changes:

several performance improvements
match against more (malformed?) game database entries

Additional credit:

Marcel Witte (wittemar@gmail.com) for the Java workaround
Konovalov Nikolay for the more efficient executable name matching

XenHat · 2025-03-17T21:11:55Z

I've been using this for a few days, seems to be working as intended.
Testing needs to be done on Windows by users of this operating system.

XenHat · 2025-04-25T05:34:34Z

~~Known issue: The Elder Scrolls IV: Oblivion Remastered isn't detected properly in the new code. An up-to-date detectable.json works with the code prior to this PR but does not with my new code.~~ Fixed

ikaikahub · 2025-05-21T22:17:35Z

fixes my issue with running thcrap patched touhou 7, cool pr

src/process/index.js

Some games are listed in the discord game database with their parent directories but their launched processes on linux don't always have this included in cmdline. This fixes that by checking processes with their working directories as well. For example, this will now detect DOOM Eternal running through proton.

src/process/index.js

konovalov-nk · 2026-02-09T15:04:42Z

Last but not least, please lets use const, let, === and all the standard ES6+ things :)

src/process/index.js

src/process/native/index.js

src/process/native/linux.js

scripts/ignore.test.js

XenHat

Looks good so far. I tried to reduce as many changes as possible.

changes: - several performance improvements - match against more (malformed?) game database entries - added simple unit tests

eliaswen · 2026-02-17T15:11:43Z

I would suggest adding Counter Strike 2 to this list, given it's one of the major multiplayer games that has a native linux build.

XenHat · 2026-02-17T18:27:02Z

I would suggest adding Counter Strike 2 to this list, given it's one of the major multiplayer games that has a native linux build.

Absolutely! I'll install it and fix it soon. I wish Discord were doing a better job with their database, I have to add many titles by hand.

XenHat marked this pull request as draft March 13, 2025 16:41

This comment was marked as outdated.

Sign in to view

XenHat marked this pull request as ready for review March 13, 2025 17:02

XenHat mentioned this pull request Apr 5, 2025

Improve linux game detection #92

Open

XenHat marked this pull request as draft April 14, 2025 19:01

XenHat force-pushed the improved-detection-fixes branch 2 times, most recently from 4f79e57 to 4de0038 Compare April 20, 2025 04:15

XenHat marked this pull request as ready for review April 22, 2025 19:34

XenHat marked this pull request as draft April 25, 2025 05:28

XenHat force-pushed the improved-detection-fixes branch 2 times, most recently from dfea808 to 10d9750 Compare April 25, 2025 23:45

XenHat mentioned this pull request Apr 27, 2025

detectable.json: minor fixes #140

Open

balta3 reviewed Jun 29, 2025

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

XenHat changed the title ~~Improved detection fixes~~ Improved Linux detection fixes Jul 5, 2025

This comment was marked as resolved.

Sign in to view

XenHat marked this pull request as ready for review August 31, 2025 02:54

konovalov-nk reviewed Sep 4, 2025

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

konovalov-nk reviewed Sep 4, 2025

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

konovalov-nk reviewed Sep 5, 2025

View reviewed changes

src/process/index.js Show resolved Hide resolved

XenHat force-pushed the improved-detection-fixes branch 4 times, most recently from 57721dc to 2aba85d Compare September 10, 2025 18:32

neptuwunium reviewed Dec 30, 2025

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

XenHat force-pushed the improved-detection-fixes branch from 42b80ec to ddd283e Compare January 3, 2026 20:33

Justsnoopy30 added 2 commits January 3, 2026 15:35

process: small fix for false positives

d49e76a

XenHat force-pushed the improved-detection-fixes branch from ddd283e to 88e1b34 Compare January 3, 2026 20:36

XenHat force-pushed the improved-detection-fixes branch 2 times, most recently from bb16b9c to a4600ff Compare January 11, 2026 23:24

XenHat marked this pull request as draft February 9, 2026 13:57

XenHat requested a review from konovalov-nk February 9, 2026 13:57

konovalov-nk reviewed Feb 9, 2026

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

konovalov-nk reviewed Feb 9, 2026

View reviewed changes

src/process/index.js Show resolved Hide resolved

konovalov-nk reviewed Feb 9, 2026

View reviewed changes

src/process/index.js Outdated Show resolved Hide resolved

XenHat commented Feb 9, 2026

View reviewed changes

src/process/index.js Show resolved Hide resolved

konovalov-nk reviewed Feb 10, 2026

View reviewed changes

src/process/native/index.js Show resolved Hide resolved

konovalov-nk reviewed Feb 10, 2026

View reviewed changes

src/process/native/linux.js Outdated Show resolved Hide resolved

konovalov-nk reviewed Feb 10, 2026

View reviewed changes

scripts/ignore.test.js Outdated Show resolved Hide resolved

XenHat force-pushed the improved-detection-fixes branch 2 times, most recently from 2b6d8bd to d3ec42b Compare February 12, 2026 23:52

XenHat commented Feb 12, 2026

View reviewed changes

XenHat force-pushed the improved-detection-fixes branch 6 times, most recently from f43637f to 07b78d7 Compare February 13, 2026 01:13

process: further improve game detection for Linux

ea121fe

changes: - several performance improvements - match against more (malformed?) game database entries - added simple unit tests

XenHat force-pushed the improved-detection-fixes branch from 07b78d7 to ea121fe Compare February 13, 2026 01:15

process: add Black Mesa for Linux

3c0e547

process: add Counter-Strike 2 for Linux

04ee494

Uh oh!

Comments

Conversation

XenHat commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

XenHat commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XenHat commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikaikahub commented May 21, 2025

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

konovalov-nk commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XenHat left a comment

Choose a reason for hiding this comment

Uh oh!

eliaswen commented Feb 17, 2026

Uh oh!

XenHat commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

XenHat commented Mar 13, 2025 •

edited

Loading

XenHat commented Mar 17, 2025 •

edited

Loading

XenHat commented Apr 25, 2025 •

edited

Loading