Added CommandLine arguments support for Windows & Added Mindustry JAR in detectable.json#163
Open
abi9000 wants to merge 3 commits intoOpenAsar:mainfrom
Open
Added CommandLine arguments support for Windows & Added Mindustry JAR in detectable.json#163abi9000 wants to merge 3 commits intoOpenAsar:mainfrom
abi9000 wants to merge 3 commits intoOpenAsar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"args" weren't showing up in src\process\index.js and instead resulted in undefined. Source of the issue was src\process\native\win32.js not including "CommandLine" in the wmic command. Now, arguments should work properly.
This is also the reason why the Mindustry JAR version was added into detectable.json, since I play Mindustry with a JAR which conflicted with Minecraft: Java Edition. This patch fixes that issue by distinguishing between both.