refactor: add timeout and max_retries for OpenAI SDK v1.0 compatibility#510
Open
Tushar9184 wants to merge 1 commit intoOpenBMB:chatdev1.0from
Open
refactor: add timeout and max_retries for OpenAI SDK v1.0 compatibility#510Tushar9184 wants to merge 1 commit intoOpenBMB:chatdev1.0from
Tushar9184 wants to merge 1 commit intoOpenBMB:chatdev1.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @maintainer, thank you for the feedback.
I have updated the PR to target the chatdev1.0 branch. Since the proxies argument was already removed in this branch, I have implemented the following logical changes:
Added timeout=60.0 and max_retries=3 to the OpenAI client initialization to improve reliability and handle network latencies better in the new SDK.
Reverted the non-functional comment changes in embedding.py to keep the codebase clean.
I believe this makes the client more robust for users on the latest OpenAI SDK. Ready for your review