Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,10 @@ describe("NewConversationButton", () => {
path: "/workspace/project/repo1",
},
]);
vi.spyOn(AgentServerConversationService, "createConversation").mockImplementation(
() => new Promise(() => {}),
);
vi.spyOn(
AgentServerConversationService,
"createConversation",
).mockImplementation(() => new Promise(() => {}));

const user = userEvent.setup();
renderWithProviders(<NewConversationButton />);
Expand Down Expand Up @@ -188,6 +189,75 @@ describe("NewConversationButton", () => {
expect(screen.getByTestId("new-conversation-popover")).toBeInTheDocument();
});

it("opens the conversation in a new tab when cmd/ctrl-clicking a workspace", async () => {
useWorkspacesStore.getState().addWorkspaces([
{
id: "/workspace/project/repo1",
name: "repo1",
path: "/workspace/project/repo1",
},
]);
const navigate = vi.fn();
vi.spyOn(
AgentServerConversationService,
"createConversation",
).mockResolvedValue(makeStartTask("conv-cmd-1"));

const newTab = {
location: { href: "" },
close: vi.fn(),
} as unknown as Window;
const openSpy = vi.spyOn(window, "open").mockReturnValue(newTab);

const user = userEvent.setup();
renderWithProviders(<NewConversationButton />, {
navigation: { navigate, currentPath: "/conversations" },
});

await user.click(screen.getByTestId("new-conversation-button"));
await user.keyboard("{Meta>}");
await user.click(screen.getByRole("button", { name: "repo1" }));
await user.keyboard("{/Meta}");

await waitFor(() => {
expect(openSpy).toHaveBeenCalledWith("about:blank", "_blank");
});
await waitFor(() => {
expect(newTab.location.href).toBe("/conversations/conv-cmd-1");
});
expect(navigate).not.toHaveBeenCalled();
});

it("closes the pre-opened tab when conversation creation fails on cmd/ctrl-click", async () => {
useWorkspacesStore.getState().addWorkspaces([
{
id: "/workspace/project/repo1",
name: "repo1",
path: "/workspace/project/repo1",
},
]);
vi.spyOn(
AgentServerConversationService,
"createConversation",
).mockRejectedValue(new Error("create failed"));

const close = vi.fn();
const newTab = { location: { href: "" }, close } as unknown as Window;
vi.spyOn(window, "open").mockReturnValue(newTab);

const user = userEvent.setup();
renderWithProviders(<NewConversationButton />);

await user.click(screen.getByTestId("new-conversation-button"));
await user.keyboard("{Meta>}");
await user.click(screen.getByRole("button", { name: "repo1" }));
await user.keyboard("{/Meta}");

await waitFor(() => {
expect(close).toHaveBeenCalled();
});
});

it("keeps the popover open when conversation creation fails", async () => {
const navigate = vi.fn();
const createSpy = vi
Expand Down
99 changes: 0 additions & 99 deletions __tests__/components/features/home/new-conversation.test.tsx

This file was deleted.

29 changes: 0 additions & 29 deletions __tests__/components/features/home/repo-connector.test.tsx

This file was deleted.

Loading
Loading