Merged
Conversation
simonrosenberg
force-pushed
the
feat/acp-tool-call-visualization
branch
from
e8e9207 to
df4e1b5
Compare
ACPAgent previously discarded all tool call data from the ACP server,
emitting only a single MessageEvent with the final text. This change
surfaces the complete execution trajectory through the event system.
- Add ACPToolCallEvent (extends Event, not LLMConvertibleEvent) with
fields: tool_call_id, title, status, tool_kind, raw_input, raw_output
- Accumulate ToolCallStart/ToolCallProgress in _OpenHandsACPBridge
- Emit ACPToolCallEvent for each tool call before the final MessageEvent
- Register in EVENT_VISUALIZATION_CONFIG for visualizer rendering
- Remove misleading SystemPromptEvent ("Tools Available: 0") from ACP
- Strip CLAUDECODE env var so official ACP server works inside Claude Code
- Switch example to official @zed-industries/claude-code-acp package
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonrosenberg
force-pushed
the
feat/acp-tool-call-visualization
branch
from
df4e1b5 to
fa69108
Compare
Contributor
API breakage checks (Griffe)Result: Passed |
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
ACP agent output now shows a "System Prompt" section explaining that the prompt and tools are managed by the ACP server, giving visual parity with regular agent conversations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
simonrosenberg
changed the title
neubig
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACPToolCallEvent— surfaces ACPToolCallStart/ToolCallProgressnotifications as OpenHands events, rendered in the visualizer before the final agent messageCLAUDECODEenv var so the official@zed-industries/claude-code-acpserver can start when running inside Claude CodeSystemPromptEventwith "Tools Available: 0" since the ACP server manages its own prompt and toolsInput: {}when raw_input is an empty dictTest plan
uv run pytest tests/sdk/agent/test_acp_agent.py -v— 53 tests pass (7 new)uv run pytest tests/sdk/ -q— no regressionsuv run ruff check && uv run ruff format --check— lint cleanuv run python examples/01_standalone_sdk/40_acp_agent_example.py— verify tool calls render before final message🤖 Generated with Claude Code
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:e4beaf0-pythonRun
All tags pushed for this build
About Multi-Architecture Support
e4beaf0-python) is a multi-arch manifest supporting both amd64 and arm64e4beaf0-python-amd64) are also available if needed