Add color correction and dvr-reencode#115
Conversation
|
Hi! Thanks for nice feature!
Regarding CPU utilization, I didn't notice any problems at all - the load seemingly doesn't change whether reencode is enabled or disabled. about 25-28 % utilization Unfortunately, I don't have the ability to measure latency. I noticed one issue with DVR recording: if you select h264 codec and enable reencode, the recording won't play in the built-in DVR player (if you download the video to the main computer, it opens correctly). With h265 codec everything is fine. My system settings have h265 codec enabled as well, if that's important. Could you recheck this on your setup ? I'm also attaching videos - DVR with "record OSD in DVR" option enabled and disabled. Is this expected behavior? "record OSD in DVR" switch adds/removes link quality widget in the top right corner of DVR and possibly other such widgets like IN216. 265codec_60fps_on_osd_recording 265codec_60fps_off_osd_recording dvr with color enchancment system utilization while recording dvr with reencode to 265 codec 60fps osd disabled system utilization withour reencode and color enchancment (stock default case) |
|
@DmtryJS You are correct, the "record OSD in DVR" only records the osd generated from the VRX, not the one which alreaday was in the video. DVR in mixed h264/h265 modes. This is actually a bug in the DVR player. Currently DVR assumes the recorded video to be in the formart your are currently receiving live video. It does not auto detect the format. I would like to fix this outside this PR in order to not make it too large. Feel free to create an issue for this. There is another issue with the DVR. |
|
Hi! I tried the latest build, color correction and re-encoding work great, and playback of DVR recorded with the H.265 codec now works. Interesting feature of recording two streams simultaneously: if you select GS rendering set to VTX and VRX, you get two streams — one completely clean without any OSD, and the second with OSD (there is an issue with OSD rendering if the resolution in Pixelpilot differs from the actual display resolution, for example, my display only supports 1440x1440 and there's no way to change that, but that's a separate problem, not part of this request). |
This PR introduces DRM and GPU-accelerated color correction, a hardware re-encoder for DVR recording, OSD-recording.
Key Features
This was heavily inspired by @sickgreg's patch.
AI assisted code.