Fix: avoid throwing MissingSamlUserInfoError when remote/x509 header … #7328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is present Signed-off-by: Jan Krcmar <[email protected]>
honza801
force-pushed
the
fix/missing-saml-error-remote-auth
branch
from
ed50473 to
a639fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er is present
Description
Fix logic that raised MissingSamlUserInfoError during remote/x509 authentication even when the remote header existed. Now the code only throws MissingSamlUserInfoError if neither SAML nor remote/x509 auth info is available; MissingHeaderError remains for the case where remote auth is configured but the header is missing.
This was broken in 7.0.1 by commit c22c843
Branches to which this PR applies