feat: Add placeholder _log() implementation for ServerlessBackend #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a local file-based placeholder for ServerlessBackend._log() to unblock usage of ServerlessBackend with code that calls model.log(). Changes: - Writes trajectory groups to local JSONL files using same format as LocalBackend - Uses /tmp/serverless-training-logs by default (configurable via ART_SERVERLESS_LOG_DIR) - Organizes logs by model name, split, and step number - Marked with TODO for future proper serverless API implementation This allows ServerlessBackend to be used immediately while proper remote logging is being developed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
bradhilton
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a local file-based placeholder for ServerlessBackend._log() to unblock usage of ServerlessBackend with code that calls model.log().
Changes:
This allows ServerlessBackend to be used immediately while proper remote logging is being developed.
🤖 Generated with Claude Code