Feature: add new formatters for Location and Rooms #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseylocker
requested changes
Jan 28, 2026
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
Unrelated to the purpose of the PR but a duplicate Swagger schema class is causing swagger generation to fail so the automated tests are killing the pr.
Also, as per @smarcet we need unit test coverage in all new PRs for anything but documentation.
Other than that this looks good so it's close.
andrestejerina97
force-pushed
the
feature/add-location-formatters
branch
from
b2efd7c to
364e36a
Compare
Contributor
Author
|
Ready for review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b892xue