Open
Conversation
Merge Himanshu's fix into the repository: https://github.com/EricWhiteDev/Open-Xml-PowerTools/pull/15/files Related work items: #7998
Author
|
One possible stacktrace... My fix closes about 12 leaks. I have only one path here. |
|
@Lotes thanks for saving me some work with your fix! Since this fork doesn't seem to be maintained, is there any chance we could direct your fix towards another actively maintained fork? Looking over the forks, I see that https://github.com/Codeuctivity/OpenXmlPowerTools might be a candidate. @stesee could you shed some light on the status of that fork and its willingness to accept other PRs? Thank you! |
|
Status: Pet Project |
|
FYI, we decided to go a different route but I appreciate your quick responses. Thank you guys! |
This was referenced Jul 9, 2023
huan086
pushed a commit
to huan086/Open-Xml-PowerTools
that referenced
this pull request
Sep 17, 2024
…ocumentFormat.OpenXml-2.14.0 Bump DocumentFormat.OpenXml from 2.13.1 to 2.14.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You need to dispose the stream. Otherwise when two parts use the same resource it will complain about multiple opened streams when package is in "UpdateMode". This change was done on top of Pullrequest #15.