Return raw image bytes for non-windows platforms in the ImageHandler#40
Open
kostya9 wants to merge 1 commit intoOpenXmlDev:vNextfrom
Open
Return raw image bytes for non-windows platforms in the ImageHandler#40kostya9 wants to merge 1 commit intoOpenXmlDev:vNextfrom
kostya9 wants to merge 1 commit intoOpenXmlDev:vNextfrom
Conversation
|
@EricWhiteDev are you considering merging this? |
|
Now I can use it on Blazor Webassembly thanks to your code, in this way: |
|
Thank you for the code :) Helps ma also with a net6+ app :) |
|
@EricWhiteDev This would be a major improvement, these tools are SO close to being cross-platform. Any chance of a merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, in the latest versions of .NET, the System.Drawing namespace (therefore, Bitmap class) has become non-usable on linux.
In this MR, I add raw image bytes to the ImageInfo class that is provided as an argument to ImageHandler. For those needing Bitmap and for backwards compatibility, I left the previous behavior that exposed Bitmap object, but it is evaluated lazily on demand