-
Notifications
You must be signed in to change notification settings - Fork 93
Multi-Target build #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Multi-Target build #579
Conversation
This reverts commit c360351.
Co-authored-by: Zoltán Lehóczky <[email protected]>
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageVersion Include="Microsoft.AspNetCore.Authentication.Facebook" Version="8.0.15" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could clean some of these as OCC doesn't use them. Not sure though if they could not be potentially used. I've copied OC configs for these.
|
hmm, ok, so the CI uses some Powershell scripts from Lombiq repository which builds with .NET 8.0.301. |
| @@ -1,5 +1,4 @@ | |||
| * text=auto | |||
| *.cs text eol=crlf | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ended up to be the issue with CI. The Analyzer doesn't like it on "comment lines".
Directory.Packages.props
Outdated
| <LombiqHelpfulLibrariesVersion>12.1.0</LombiqHelpfulLibrariesVersion> | ||
| <LombiqTestsUIVersion>12.1.1-alpha.14.osoe-1057</LombiqTestsUIVersion> | ||
| <!-- This needs to be upgraded to 9.0. It's currently fixed to 8.0 for CI to build without issues.--> | ||
| <AnalysisLevel>8.0</AnalysisLevel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed AnalysisLevel to 8.0 but I may try upgrading it now that I found the issue with the CI build.
|
I think this line is causing issues with the Unit Tests as the .net framework is hard coded to 8.0.510501 https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/test-dotnet/action.yml#L90 |
|
Tests are stuck in an infinite loop "I think". |
|
The |
|
From what I've seen in previous steps. It will download both net8.0 and net9.0 and compile it with both. Then these tests are now running with net8.0 because I made the DefaultTargetFramework to be net8.0. But it should normally test for both net8.0 and net9.0 and from what I've seen the test step action is hard coded to run with net8.0. |
|
@Piedone @sarahelsaig Things like permission issues on Linux: And under Windows I'm getting something related with Docker failing. So far, it feels like I can't fix these or I need to know the Lombiq stack. |
|
I won't be able to help with this, sorry. |
|
Ok so, I fixed the Unit Tests by removing the SecurityScanningTest but one issue remains and it is related with: This is an issue on Lombiq Github actions where when running the tests it only installs .NET 9 for some reason. I am stopping progress on this one for now. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |


To merge on top of OCC-314. I can retarget when the PR gets merged.