Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a centralized logging configuration system for the dftt_timecode library and fixes a bug in the __validate_drop_frame method where the wrong variable was referenced.
Key changes include:
- Implementation of automatic log level detection based on git branch (DEBUG for dev branches, INFO for main/installed packages)
- Comprehensive test coverage for the new logging configuration module
- Migration from hardcoded logging setup to the new centralized logging system
- Bug fix: corrected variable reference in
__validate_drop_framefromself.fpstofps
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_logging_config.py | Adds comprehensive test suite for logging configuration functionality including git branch detection, log level determination, and integration tests |
| dftt_timecode/logging_config.py | Implements new centralized logging configuration module with automatic log level detection based on git branch and environment variables |
| dftt_timecode/core/dftt_timerange.py | Migrates to new logging system and adds debug/error logging throughout timerange operations |
| dftt_timecode/core/dftt_timecode.py | Replaces manual logging setup with new logging system, fixes bug in fps validation, and improves error handling in timecode conversion |
| dftt_timecode/init.py | Exports new logging configuration functions for public API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
OwenYou
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.