Skip to content

add logging config and fix bug#35

Merged
OwenYou merged 2 commits intomainfrom
dev
Oct 23, 2025
Merged

add logging config and fix bug#35
OwenYou merged 2 commits intomainfrom
dev

Conversation

@WheheoHu
Copy link
Collaborator

No description provided.

@WheheoHu WheheoHu requested review from OwenYou and Copilot October 23, 2025 10:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a centralized logging configuration system for the dftt_timecode library and fixes a bug in the __validate_drop_frame method where the wrong variable was referenced.

Key changes include:

  • Implementation of automatic log level detection based on git branch (DEBUG for dev branches, INFO for main/installed packages)
  • Comprehensive test coverage for the new logging configuration module
  • Migration from hardcoded logging setup to the new centralized logging system
  • Bug fix: corrected variable reference in __validate_drop_frame from self.fps to fps

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/test_logging_config.py Adds comprehensive test suite for logging configuration functionality including git branch detection, log level determination, and integration tests
dftt_timecode/logging_config.py Implements new centralized logging configuration module with automatic log level detection based on git branch and environment variables
dftt_timecode/core/dftt_timerange.py Migrates to new logging system and adds debug/error logging throughout timerange operations
dftt_timecode/core/dftt_timecode.py Replaces manual logging setup with new logging system, fixes bug in fps validation, and improves error handling in timecode conversion
dftt_timecode/init.py Exports new logging configuration functions for public API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@OwenYou OwenYou merged commit d95393d into main Oct 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants