Fix FCPX format output for fractional timestamps#37
Merged
OwenYou merged 1 commit intoOwenYou:mainfrom Nov 10, 2025
Merged
Conversation
Fixed a bug in _convert_to_output_fcpx method where the denominator of fractional timestamps was missing the forward slash separator. Previously, fractional timestamps like Fraction(5, 2) would output as "52s" instead of the correct FCPX format "5/2s". This fix ensures the denominator includes the "/" prefix when the timestamp is not an integer, producing valid FCPX time format.
OwenYou
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in _convert_to_output_fcpx method where the denominator of fractional timestamps was missing the forward slash separator.
Previously, fractional timestamps like Fraction(5, 2) would output as "52s" instead of the correct FCPX format "5/2s".
This fix ensures the denominator includes the "/" prefix when the timestamp is not an integer, producing valid FCPX time format.