Open
Conversation
72007ff to
c36ece5
Compare
dbeuchler
reviewed
Jan 5, 2026
Member
There was a problem hiding this comment.
I have done a really short review and found a lot of code issues that were removed from all modules in MORYX 10. Before this is merged, this should definitely be cleaned up. All new patterns that we have applied to other modules should also be applied here. Tests and documentation is completely missing. Nondescriptive PR title / description
src/Moryx.Maintenance.Endpoints/Dtos/GetAllMaintenanceOrderResponse.cs
Outdated
Show resolved
Hide resolved
src/Moryx.Maintenance.Endpoints/StreamServices/MaintenanceEventArg.cs
Outdated
Show resolved
Hide resolved
src/Moryx.Maintenance.Endpoints/Moryx.Maintenance.Endpoints.csproj
Outdated
Show resolved
Hide resolved
src/Moryx.Maintenance.Endpoints/Moryx.Maintenance.Endpoints.csproj
Outdated
Show resolved
Hide resolved
src/Moryx.Maintenance.Management/Implementations/MaintenanceManager.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The unit test and documentation will be added in the future. an issue has already been created for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the maintenance scheduler API, endpoints and UI from MORYX 8 (gitlab) to MORYX 10.
For those who don't know about this module. Here is a quick recap:
Maintenance Scheduler API:
This module allows the scheduling of maintenance for machines in the manufacturing factory.
Concepts :
Maintenance Orderis generated.IMaintenanceManagement :
This is the facade through which other module or service can interact with the Maintenance Scheduler The facade contains:
These functions/methods allow you to create,edit and delete a maintenance order. It also contains events :
These events are used to notify subscibers of any important actions or events that happens in the Maintenance Scheduler.
IMaintainableResource
An IMaintainableResource is a machine that can receive a maintenance order/command. Every machine that implements this interface are tracked by the
Maintenance Scheduler. It contains theStartMaintenancemethod which is invoked when a maintenance should be performed on the machine. It also contains events such as:There events are raised by the
machineto notify the IMaintenanceManagement.Preview:
Breaking Changes
Checklist for Submitter
Review
Typical tasks
Clean code