✨ New Universal.Attributes.TrailingComma sniff
#413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New sniff to require a trailing comma for multi-line, multi-attribute attribute blocks and forbid trailing commas in single-line attribute blocks and multi-line attributes containing only a single attribute. While trailing commas is not covered by PERCS, this sniff as proposed does not conflict with the expectations of PERCS. Includes fixer. Includes metrics. Includes unit tests. Includes documentation. Fixes 397
jrfnl
force-pushed
the
feature/397-new-universal-attributes-trailingcomma-sniff
branch
from
82dbaa0 to
2f0a883
Compare
jrfnl
deleted the
feature/397-new-universal-attributes-trailingcomma-sniff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New sniff to require a trailing comma for multi-line, multi-attribute attribute blocks and forbid trailing commas in single-line attribute blocks and multi-line attributes containing only a single attribute.
While trailing commas is not covered by PERCS, this sniff as proposed does not conflict with the expectations of PERCS.
Includes fixer.
Includes metrics.
Includes unit tests.
Includes documentation.
Fixes #397