Skip to content

Conversation

@ProgMiner
Copy link
Contributor

No description provided.

Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
@ProgMiner ProgMiner requested a review from Kakadu as a code owner June 18, 2025 01:31
Copy link
Collaborator

@Kakadu Kakadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is PR is not consequent.
It doesn't give any useful API (IMHO), but introduced a function which is never used. In one of last PRs you were removing functions which are not used anywhere, why the one should remove these function in the next PR?

@Kakadu Kakadu marked this pull request as draft June 18, 2025 19:21
@ProgMiner
Copy link
Contributor Author

ProgMiner commented Jun 18, 2025

I've used these functions while debugging an error message "OCanren fatal (Env.check): wrong environment". It's true, that they aren't helpful without any other changes (e.g. printing environment in Term.Var.describe) and may be removed as unused but they aren't introduce any non-trivial logic that could trouble subsequent development.

IMO, any type must provide pretty-printing functions even if they aren't used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants