Skip to content

Conversation

@tiekneeshrimp
Copy link
Contributor

Resolves issue 14 on branch 18

@tiekneeshrimp tiekneeshrimp self-assigned this Oct 23, 2024
@tiekneeshrimp tiekneeshrimp linked an issue Oct 23, 2024 that may be closed by this pull request
@tiekneeshrimp
Copy link
Contributor Author

*merging to main just to add to media files

@tiekneeshrimp tiekneeshrimp reopened this Oct 23, 2024
@tiekneeshrimp tiekneeshrimp requested review from VicTorres23, djinnome and mcnaughtonadm and removed request for VicTorres23 October 23, 2024 19:42
@tiekneeshrimp
Copy link
Contributor Author

Might merge to main regardless of failed checks--just to add to media files

@djinnome
Copy link
Contributor

Interesting reason for the failed check. I agree that we can probably separate the check failure into a separate PR.

Copy link
Contributor

@mcnaughtonadm mcnaughtonadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff fail is saying that whatever model memote is using to check against the media doesn't have all the reactions in it. This is pulling the model that lives on main to do this. If we don't have the specific reactions in the model on main it could be the reason this is being returned.

I did some manual inspection of the main model and it looks like it has these reactions so not sure why the diff is complaining. Overall the diff is not critical to pass as the other reports are generated with the merge.

I agree we can override this for now.

@mcnaughtonadm mcnaughtonadm merged commit dfc0e91 into main Oct 23, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of four elements to minimal media files

4 participants