Skip to content

Conversation

@mcnaughtonadm
Copy link
Collaborator

This PR will address #15 .

To be able to utilize a template JSON file with the emll code. It is necessary to break the components needed to run the ADVI into their own methods. Here we break the scripts present in the run_hackett_inference.py into a separate class called BMCA (can be renamed to whatever, this is just a placeholder) that loads the cobra model, along with the paths to the various data sources.

@mcnaughtonadm
Copy link
Collaborator Author

The line:
https://github.com/PNNL-CompBio/emll/blob/cfe80dc70c58d5a639df9c6311d41c47c1d7b1fe/src/emll/bmca.py#L72

should be rewritten to accept any type of cobra model input.

@mcnaughtonadm mcnaughtonadm self-assigned this Jan 30, 2024
@mcnaughtonadm mcnaughtonadm added the enhancement New feature or request label Jan 30, 2024
@mcnaughtonadm mcnaughtonadm linked an issue Jan 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break run_hackett_inference.py into methods

3 participants