Fix incorrect rust-version field name #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! That's something that Cargo could catch. |
Merged
4 tasks
Contributor
Author
|
@PSeitz thanks! now it works without upper-bounding the crate version 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great work 💪
Sadly the field name for the
rust-versionwas misspelled and it broke our MSRV check in https://github.com/open-telemetry/opentelemetry-rust-contribIt would be possible to release a new version with the fix and yank the recently published one
0.11.4? We are using the quite new dependency version fallback resolver to automatically download the highest supported version and because of the misspelled field name it will downloaded in projects with a lower MSRV of 1.81.