Move CI to jobs in single workflow #206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Looks like using a matrix is a good way to go. Could you revise this PR? |
This commit moves CI from individual workflows to a series of jobs in a single workflow. This allows jobs to share the same triggers and environment variables. This can be further simplified in a future commit by using a matrix to share common installation and build logic between jobs.
williamjallen
force-pushed
the
workflows-to-jobs
branch
from
53230e6 to
f3e8ae6
Compare
Contributor
Author
|
@wkliao I just updated this PR with the most recent CI changes. This PR simply copies and pastes everything as-is into a single workflow. This means that all the jobs now share the same workflow triggers and environment variable definitions. Since this is already such a large PR, my plan is to create a series of smaller follow-up PRs to gradually reduce the amount of duplication via a matrix. Let me know if you'd like me do anything differently! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves CI from individual workflows to a series of jobs in a single workflow. This allows jobs to share the same triggers and environment variables. This can be further simplified in a future commit by using a matrix to share common installation and build logic between jobs.