Do not remember and restore brackets when using SyntaxDescriptor#181
Open
GabCard wants to merge 1 commit intoPavelTorgashov:masterfrom
Open
Do not remember and restore brackets when using SyntaxDescriptor#181GabCard wants to merge 1 commit intoPavelTorgashov:masterfrom
GabCard wants to merge 1 commit intoPavelTorgashov:masterfrom
Conversation
Do not call this methods because it overrides the configuration inside the xml file
Contributor
Author
|
Hello, I'm just wondering if you will accept/merge my two remaining pull request? Do you have any questions about them? |
Collaborator
|
@GabCard I do not think we want to remove that behavior entirely, however perhaps adding a flag or something of the sort that would disable that behavior in the case of xml description for syntax highlighting would be a better idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not remember and restore brackets configuration in
HighlightSyntax(SyntaxDescriptor desc, Range range), because it overrides the brackets configuration you put in the xml file description.