Use consistent line endings in source code#1625
Draft
arteymix wants to merge 1 commit intohotfix-1.32.7from
Draft
Use consistent line endings in source code#1625arteymix wants to merge 1 commit intohotfix-1.32.7from
arteymix wants to merge 1 commit intohotfix-1.32.7from
Conversation
arteymix
changed the title
arteymix
force-pushed
the
fix-line-endings
branch
from
f4c1eb7 to
923c459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just ran into some issues with bundling Gemma on OS X that was tracked down to the way line endings were interpreted by Webpack. To prevent further issues of the kind in the future, we should only use LF endings in source code.