[Gridsynth 1] Gridsynth decomposition #2140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephleekl
changed the title
Co-authored-by: Sengthai Heng <[email protected]>
paul0403
reviewed
Dec 3, 2025
paul0403
reviewed
Dec 3, 2025
sengthai
reviewed
Dec 3, 2025
Contributor
sengthai
left a comment
sengthai
left a comment
There was a problem hiding this comment.
Nice~ I have a few comments. 🚀
paul0403
added a commit
that referenced
this pull request
Dec 4, 2025
**Context:** One of the first steps in the compilation pipeline is `--inline-nested-modules`. This pass lifts the per-qnode module up into the global module of the qjit. Because (usually) the symbol table of a module is isolated from above, multiple modules in parallel may contain the same names inside. Therefore when inlining child modules into the global module, we need to rename them to unique names. However, there's a small problem. Each qnode module has their own specific transform sequence, so the quantum passes (applied during `--apply-transform-sequence`) have to be resolved before `--inline-nested-module`. If a pass generates a function declaration to an external API (e.g. runtime functions), that name must not be altered. **Description of the Change:** Do not perform renaming on external function declarations from within the qnode modules during `--inline-nested-modules`. Only inline the first occurrence of such func decls from the qnode modules into the global qjit module. **Benefits:** Quantum passes that generate calls to other APIs can work. The flipside is also true! API developers do not have to maintain multiple aliases for their API functions (e.g. gridsynth pass #2140 ) [sc-105020] --------- Co-authored-by: Joseph Lee <[email protected]>
sengthai
approved these changes
Dec 5, 2025
Contributor
sengthai
left a comment
sengthai
left a comment
There was a problem hiding this comment.
Thanks @josephleekl for this PR~ 🔥✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This is the first of 2 PRs to implement the 'Gridsynth' pass in Catalyst. (Second PR). This PR only contains the MLIR pass itself, and a dummy implementation of the actual runtime discretization function in order to test the data transfer between the MLIR and the C++ runtime. The actual discretization runtime, along with python tests, will be part of the next PR.
This branch needs to be used in conjunction with the
rs-decompbranch in PennyLane.To test this:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-102150]