-
Notifications
You must be signed in to change notification settings - Fork 58
Lower ion to rtio #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rniczh
wants to merge
58
commits into
main
Choose a base branch
from
rniczh/lower-ion-to-rtio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lower ion to rtio #2204
+1,529
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
…lyst into rniczh/add-rtio-dialect
…lyst into rniczh/add-rtio-dialect
Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
…lyst into rniczh/lower-ion-to-rtio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Convert ion dialect to rtio dialect
Description of the Change:
There are several steps to convert the ion dialect to rtio dialect:
Prepare the enviorment:
qreg allocandqreg extracttomemref. In the later conversion, we use the mapping to construct the channel forrtio.pulse. It will create a global memref that contains index from 0 to N to represent the qubits.parallel protocol to rtio:
Converts
ion.parallelprotocolregions into flat RTIO operations with proper synchronization. We rely on the data dependency of qubit to introduce the unrealized conversion cast betweenion.qubitandrtio.event. That's the way how we currently build the relationship between events. Later, those unrealized conversion cast will be removed via event propagation.Input mlir:
ion.pulsetortio.pulse:Converts
ion.pulsetortio.pulsewith calculated frequency.Frequency Calculation:
frequency = (reference_energy + detuning - raman1_frequency) / (2 * pi)Steps:
rtio.channelviartio.qubit_to_channelrtio.pulseoperationResolve channel mapping
Resolves dynamic channel references to static channel IDs.
propagate events
Resolves
unrealized_conversion_castand connect the ops with event typeSteps:
quantum.AllocOp: creatertio.emptyRemove all other dialects:
Removes unused quantum/ion/memref/linalg dialect after conversion.
TODOs:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-100851]